Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing sorting of terms bucket #22919

Merged
merged 2 commits into from
Sep 11, 2018
Merged

fixing sorting of terms bucket #22919

merged 2 commits into from
Sep 11, 2018

Conversation

ppisljar
Copy link
Member

Fixes #22918

@ppisljar ppisljar added review Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v7.0.0 v6.5.0 labels Sep 11, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

markov00
markov00 approved these changes Sep 11, 2018
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Pulled PR and tested, everything is fine!

@ppisljar ppisljar merged commit 9b88951 into elastic:master Sep 11, 2018
@ppisljar ppisljar mentioned this pull request Sep 11, 2018
Merged
@ppisljar ppisljar deleted the fix/aggconfigrefactor branch September 11, 2018 14:10
ppisljar added a commit to ppisljar/kibana that referenced this pull request Sep 12, 2018
@ppisljar
fixing sorting of terms bucket (elastic#22919)
d1574a0
ppisljar added a commit that referenced this pull request Sep 12, 2018
@ppisljar
fixing sorting of terms bucket (#22919) (#22926)
2b1dacc
@ppisljar ppisljar restored the fix/aggconfigrefactor branch September 26, 2018 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

@lukeelmers lukeelmers Awaiting requested review from lukeelmers

Assignees
No one assigned
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v6.5.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ppisljar @elasticmachine @markov00